search

JuliaStats / GLM.jl

Generalized linear models in Julia
Other
584 stars 114 forks source link

bump compat for StatsBase 0.34 #529

Closed palday closed 1 year ago

palday commented 1 year ago

see also #528

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c170e3) 87.39% compared to head (fd29f0c) 87.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1 #529 +/- ## ======================================= Coverage 87.39% 87.39% ======================================= Files 7 7 Lines 952 952 ======================================= Hits 832 832 Misses 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ararslan commented 1 year ago

Looks like CI ran with StatsBase 0.33 because something else is upper-bounding it.

ararslan commented 1 year ago

Ah, it's StatsModels. So we'll need https://github.com/JuliaStats/StatsModels.jl/pull/291

palday commented 1 year ago

Don't know why Julia nightly is failing, but the other versions run with StatsBase 0.34

image
kleinschmidt commented 1 year ago

I think nightly failures are the same as we see in StatsModels: 

saturated linear model: Error During Test at /home/runner/work/GLM.jl/GLM.jl/test/runtests.jl:207
  Expression evaluated to non-Boolean

although looking at the tests, I don't see why (in my experience this is caused by @test_broken normally accepting non-boolean values in 1.8 or earlier)

ararslan commented 1 year ago

We could backport https://github.com/JuliaStats/GLM.jl/pull/514 to the v1 branch. That PR fixed that issue.