JuliaStats / GLM.jl

Generalized linear models in Julia
Other
584 stars 114 forks source link

Set minimum Julia version to 1.6 (#514) #530

Closed palday closed 1 year ago

palday commented 1 year ago

Currently the minimum version is 1.0, which is old and unsupported and makes development and addition of new features more difficult.

In Julia 1.10, at-test_broken will error if the expression doesn't evaluate to a boolean value, making it consistent with at-test. We actually can fit the model here; the test passes with prior Julia versions only because the expression doesn't evaluate to a boolean.

(cherry picked from commit 57669ef89de3588ffdbf757d82fd28d5c71f5177)

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (f874482) 87.39% compared to head (f874482) 87.39%.

:exclamation: Current head f874482 differs from pull request most recent head ee9b232. Consider uploading reports for the commit ee9b232 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1 #530 +/- ## ======================================= Coverage 87.39% 87.39% ======================================= Files 7 7 Lines 952 952 ======================================= Hits 832 832 Misses 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.