search

JuliaStats / GLM.jl

Generalized linear models in Julia
Other
584 stars 114 forks source link

backport of QR to 1.x #537

Open palday opened 1 year ago

palday commented 1 year ago

from #507

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 86.79% and project coverage change: +0.72 :tada:

Comparison is base (6406a70) 87.39% compared to head (cd187fb) 88.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1 #537 +/- ## ========================================== + Coverage 87.39% 88.11% +0.72% ========================================== Files 7 7 Lines 952 1077 +125 ========================================== + Hits 832 949 +117 - Misses 120 128 +8 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [src/GLM.jl](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL0dMTS5qbA==) | `60.00% <50.00%> (+10.00%)` | :arrow_up: | | [src/negbinfit.jl](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL25lZ2JpbmZpdC5qbA==) | `81.81% <66.66%> (-0.85%)` | :arrow_down: | | [src/linpred.jl](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL2xpbnByZWQuamw=) | `88.55% <83.63%> (+2.94%)` | :arrow_up: | | [src/lm.jl](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL2xtLmps) | `94.07% <97.14%> (+0.74%)` | :arrow_up: | | [src/glmfit.jl](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL2dsbWZpdC5qbA==) | `81.33% <100.00%> (+0.31%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaStats/GLM.jl/pull/537/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nalimilan commented 1 year ago

Is there any particular place we should look at (i.e. where you had to adapt the original PR)?

palday commented 1 year ago

@nalimilan if you look at the diff excluding the first commit, then you can see things that were non obvious in the cherry-pick -- one exception (not including a local fit(::Type, ::FormulaTerm,...)) method, I accepted all changes from the original PR. The follow-up modifications were related to the additional redirection from TableRegressionModel.