search

JuliaStats / GLM.jl

Generalized linear models in Julia
Other
584 stars 114 forks source link

Change dof_residual definition to not depend on dispersion parameter #560

Open andreasnoack opened 2 months ago

andreasnoack commented 2 months ago

Fixes https://github.com/JuliaStats/GLM.jl/issues/509

There was actually already a test of a model affected by this but the reference value was wrong. I checked the value in R.

@nalimilan how do you feel about dof after all these years? After preparing this, I think we might be better of from deprecating dof (which would have to happen in StatsAPI). I tend to think that it brings more confusion than convenience.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.85%. Comparing base (e2f6c98) to head (5c26648). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #560 +/- ## ========================================== - Coverage 89.86% 89.85% -0.01% ========================================== Files 8 8 Lines 1125 1124 -1 ========================================== - Hits 1011 1010 -1 Misses 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.