search

JuliaStats / GLMNet.jl

Julia wrapper for fitting Lasso/ElasticNet GLM models using glmnet
Other
96 stars 35 forks source link

Add BinaryBuilder binaries with fallback to existing source build #33

Closed JackDunnNZ closed 5 years ago

JackDunnNZ commented 5 years ago

I am trying to deploy with a dependency on GLMNet in a setting where it's unreasonable to ask Windows users to have a fortran compiler, so I wanted to add the option of pre-built binaries with a fallback to the existing source build, just in case.

This also enables testing windows on appveyor and osx on travis. I'm guessing appveyor needs to be enabled for the main repo, but it is passing on my fork: https://ci.appveyor.com/project/JackDunnNZ/glmnet-jl

The builder repo is https://github.com/JackDunnNZ/GLMNetBuilder, I am happy to transfer to JuliaStats (or anyone else) if desired.

Fixes #13

JackDunnNZ commented 5 years ago

Bump, would appreciate it if someone from @JuliaStats could look over this

simonbyrne commented 5 years ago

Thanks, sorry about the delay.

JackDunnNZ commented 5 years ago

Thanks!

JackDunnNZ commented 5 years ago

@simonbyrne would it be possible to tag a new release?

simonbyrne commented 5 years ago

done!

JackDunnNZ commented 5 years ago

Thanks so much!