search

JuliaStats / HypothesisTests.jl

Hypothesis tests for Julia
MIT License
298 stars 87 forks source link

Add methods for adjusting p values #83

Closed cjprybol closed 7 years ago

cjprybol commented 8 years ago

This is currently available in Julia via https://github.com/dirkschumacher/PValueAdjust.jl

Given that the functionality for calculating p values lives here in HypothesisTests, I thought it would be a good idea to try and implement Bonferroni, FDR, and FWER methods here as well. I saw open pull requests related to p values here https://github.com/JuliaStats/HypothesisTests.jl/pull/73 and here https://github.com/JuliaStats/HypothesisTests.jl/pull/76, but nothing for these simpler tests.

Mainly posting this here as a reminder to try and implement these myself, but any feedback on whether these already exist in JuliaStats and I missed them, that these tests should go elsewhere, or thumbs up/down voting that moving this functionality out of a the PValueAdjust package and into here is a good/bad idea is welcome

ararslan commented 8 years ago

I've been meaning for a while to add p-value adjustments here, I just haven't gotten around to it.

cjprybol commented 7 years ago

https://github.com/juliangehring/MultipleTesting.jl

ararslan commented 7 years ago

Good find, thanks Cameron.