search

JuliaStats / KernelDensity.jl

Kernel density estimators for Julia
Other
175 stars 40 forks source link

Should probably import kde from Distributions #38

Closed andreasnoack closed 5 years ago

ararslan commented 7 years ago

The only mention of kde in Distributions is here, where a comment says that it's actually coming from Stats.jl (which shouldn't even be installable anymore). As such it might make more sense to remove that mysterious export from Distributions and just defined kde here.

andreasnoack commented 7 years ago

The idea with having these definitions upstream is that several implementations can import it. If we move it to KernelDensity then other kernel density implementatinos would need to depend on KernelDensity. Maybe we want that maybe we won't. Can you find separate uses of kde?

ararslan commented 7 years ago

Based on a brief GitHub search, there are at least two packages that define their own kde without using KernelDensity.jl: KernelDensityEstimate.jl (registered), KernelEstimator.jl (registered) and ABCAuction.jl (unregistered). The latter two depend on Distributions.jl but the first does not.

matbesancon commented 5 years ago

to close? cc @andreasnoack

andreasnoack commented 5 years ago

Probably okay

matbesancon commented 5 years ago

seems reasonable to define kde in here, people which want to define their own can import it