search

JuliaStats / KernelDensity.jl

Kernel density estimators for Julia
Other
175 stars 40 forks source link

Fixes for Julia 0.7/1.0 #56

Closed awllee closed 5 years ago

awllee commented 5 years ago

Possible issues:

  1. On Julia v0.6, one of the kde_range tests was failing even before any changes were made.
  2. Base.conv is no longer overridden since it no longer exists on 0.7/1.0. I don't know if any packages were making use of this undocumented feature.
  3. I believe the Compat dependency could be removed entirely, but I haven't done this.
awllee commented 5 years ago

Failures on 1.0/nightly appear to be due to Optim.jl

simonbyrne commented 5 years ago

Thanks! If we're 0.7 only, we shouldn't need Compat.

awllee commented 5 years ago

Okay, I can remove all dependency on Compat.