search

JuliaStats / KernelDensity.jl

Kernel density estimators for Julia
Other
175 stars 40 forks source link

accessors for gridpoints and corresponding densities #67

Closed tpapp closed 4 years ago

tpapp commented 5 years ago

It is unclear if eg for univariate densities the slots x and density can be used (ie are part of the API and can be expected to be stable, not an internal implementation detail).

It would be great to document this, or alternatively provide accessor functions. Similarly for bivariate.

If the package maintainers clarify their intention, I would be happy to make a PR.

tpapp commented 5 years ago

Could also help with #66.

tpapp commented 5 years ago

Bump --- can anyone clarify this?

tpapp commented 5 years ago

@simonbyrne , can you help me with this? Again, I just need a decision on what would be preferred, happy to make the PR.

tlnagy commented 4 years ago

This package would benefit greatly from these accessors and a tutorial. I would prefer to have documented functions for access to prevent breakage if internals get moved around.

simonbyrne commented 4 years ago

I'm afraid I don't have the bandwidth to contribute to this repository for the forseeable future. @tpapp and @tlnagy I've added you as collaborators, please do as you see fit.

tpapp commented 4 years ago

@simonbyrne, are you sure you added me as a collaborator? I don't seem to have access rights. In any case, I will just fork in the meantime.

simonbyrne commented 4 years ago

Yes, check https://github.com/JuliaStats/KernelDensity.jl/invitations