search

JuliaStats / KernelDensity.jl

Kernel density estimators for Julia
Other
178 stars 40 forks source link

Document that slots can be accessed as part of the API. #72

Closed tpapp closed 5 years ago

tpapp commented 5 years ago

Fixes #67. Also documents the intepretation of the integral.

(All of these properties are already tested for.)

tpapp commented 5 years ago

@tlnagy, since you were also interested in this issue a review would be appreciated.

tlnagy commented 5 years ago

Looks good. I think that makes it a lot clearer.

Would it make more sense to use accessor functions for accessing the gridpoints and density values? It would allow for changes in the underlying type without breaking the API, but that might not be necessary.

tpapp commented 5 years ago

Thanks. Accessors are generally fine, but I want to make minimal changes for now (and later on one can always define getproperty to customize this further).

Can someone please merge this?

tpapp commented 5 years ago

friendly ping, can someone please merge this?

I would like to proceed with https://github.com/KristofferC/PGFPlotsX.jl/issues/143 which hinges on this.