search

JuliaStats / Klara.jl

MCMC inference in Julia
Other
167 stars 38 forks source link

Fix deprecations #168

Closed femtocleaner[bot] closed 7 years ago

femtocleaner[bot] commented 7 years ago

I fixed a number of deprecations for you

Keno commented 7 years ago

For future reference, if you keep the PR open, the bot will update it once it has the bugfix in its codebase.

papamarkou commented 7 years ago

Thank you Keno. If I re-open it, will it update now, or it doesn't work this way?

Keno commented 7 years ago

No, it doesn't work that way, since it won't undo the work done on master. If you want, you can revert the merging of this PR on master, then re-run femtocleaner by opening an issue with the title "Run femtocleaner" and it'll open a new PR for you.

papamarkou commented 7 years ago

It makes sense. I presume it is less hassle if I make the changes manually this time rather than reverting the merging, and next time I will keep the PR open.

Keno commented 7 years ago

Well, hopefully next time it'll get it right the first time.