search

JuliaStats / Klara.jl

MCMC inference in Julia
Other
166 stars 38 forks source link

ForwardDiff 0.4 0.6 #171

Closed montyvesselinov closed 6 years ago

montyvesselinov commented 6 years ago

REQUIRE ForwardDiff 0.4 0.6 is causing issuee.

are you going to accept latest ForwardDiff?

papamarkou commented 6 years ago

ForwardDiff v0.6 brings breaking changes. This means the upgrade is non-trivial due to having to change Klara at various points, ranging from DiffResults, to DiffConfig etc. I made a start today. It will take some time to finish, given work commitments.

montyvesselinov commented 6 years ago

I understand. SInce we are using Klara we also cannot adopt the ForwardDiff changes.

-monty

On Sun, Feb 11, 2018 at 3:10 PM, Theodore Papamarkou < notifications@github.com> wrote:

ForwardDiff v0.6 brings breaking changes. This means the upgrade is non-trivial due to having to change Klara's at various points, ranging from DiffResults, to DiffConfig etc. I made a start today. It will take some time to finish, given work commitments.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaStats/Klara.jl/issues/171#issuecomment-364794092, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXxePfupaSG1KZ3J1VOlMh2JIiKlD17ks5tT2VIgaJpZM4Rxl6F .

papamarkou commented 6 years ago

I will do my best to complete the migration within the next week or so.

papamarkou commented 6 years ago

I made Klara work with the newer version of ForwardDiff. The new version of Klara has been pushed to METADATA, awaiting to be merged.