search

JuliaStats / Lasso.jl

Lasso/Elastic Net linear and generalized linear models
Other
143 stars 31 forks source link

Fixed broken/deprecated GLM/julia calls #18

Closed AsafManela closed 5 years ago

AsafManela commented 6 years ago

This PR also adds support for penalty factors to GammaLassoPath with tests for this feature for both LassoPath and GammaLassoPath (hence the many csv files).

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 93.319% when pulling b7083ea099fdf217ab8dd1a015dbf54bd84945cc on AsafManela:master into 75d43104d7a37fed7a456658dbe71859b081f708 on simonster:master.

AsafManela commented 6 years ago

@simonster, the currently released Lasso.jl does not work with stable GLM.jl due to their interface change. This PR addresses that plus adds some features. Just wondering if you are not merging because too busy, which is understandable, or because you disagree with the changes, which I can change ;)

simonster commented 6 years ago

Sorry, I haven’t looked because I’m busy and forgot. I will try to look in the next few days.

On Jul 23, 2018, at 8:17 AM, Asaf Manela notifications@github.com wrote:

@simonster, the currently released Lasso.jl does not work with stable GLM.jl due to their interface change. This PR addresses that plus adds some features. Just wondering if you are not merging because too busy, which is understandable, or because you disagree with the changes, which I can change ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

AsafManela commented 6 years ago

Thanks!