upgraded syntax to julia 0.7/1.0

JuliaStats / Lasso.jl

Lasso/Elastic Net linear and generalized linear models

Other

143 stars 31 forks source link

upgraded syntax to julia 0.7/1.0 #19

Closed AsafManela closed 5 years ago

AsafManela commented 5 years ago

All tests pass locally on julia 0.7 and 1.0 on a linux box. Tests on julia 1.0 require GLMNet.jl's upgraded syntax as well, which is available now by running (v1.0) pkg> add GLMNet#627355f45079e305a19541fe787bf0a00ef544f7 Hopefully that pending pull request is merged soon. I don't have access to a mac box, so can't figure out why travis-ci fails to install gfortran via the gcc brew. Otherwise, if you are using linux, Lasso.jl is now working on 0.7/1.0

coveralls commented 5 years ago

Coverage increased (+0.07%) to 92.886% when pulling f6e816befe430a98869cf1dce5bb151101ca00d8 on AsafManela:am/0.7upgrade into 75d43104d7a37fed7a456658dbe71859b081f708 on simonster:master.

AsafManela commented 5 years ago

Now that GLMNet has been upgraded all tests pass. Can someone at @JuliaStats please merge and tag? Thanks!