Correct show and predict after selectmodel and remove side effects

JuliaStats / Lasso.jl

Lasso/Elastic Net linear and generalized linear models

Other

143 stars 31 forks source link

Correct show and predict after selectmodel and remove side effects #37

Closed AsafManela closed 4 years ago

AsafManela commented 4 years ago

Implements show(::RegularizedModel) to avoid issues with reporting standard errors, which are not well defined for Lasso. Now we only show the coefficient point estimates. closes #36
Fixes side effect issues with selectmodel. closes #35
Corrects some problems with predict after model selection
Updates documentation

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 180

16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.7%) to 89.124%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/segselect.jl	13	14	92.86%
<!--	Total:	16	17	94.12%	-->

Totals
Change from base Build 178:	1.7%
Covered Lines:	2024
Relevant Lines:	2271

💛 - Coveralls

oxinabox commented 4 years ago

Awesome! Has a release been tagged?

AsafManela commented 4 years ago

yes. v0.5.1 should work

Asaf

On Wed, Jan 1, 2020, 5:43 PM Lyndon White notifications@github.com wrote:

Awesome! Has a release been tagged?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/JuliaStats/Lasso.jl/pull/37?email_source=notifications&email_token=ADJM2OTQJAQ6WKTGCF3TOXLQ3UTC7A5CNFSM4JYTYYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5O6TQ#issuecomment-570093390, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJM2OSFQKDP773XGUBEYMTQ3UTC7ANCNFSM4JYTYYHA .