coveralls
commented
4 years ago Pull Request Test Coverage Report for Build 186
- 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+2.7%) to 89.313%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/segselect.jl | 6 | 7 | 85.71% | ||
| <!-- | Total: | 6 | 7 | 85.71% | --> |
| Totals | |
|---|---|
| Change from base Build 184: | 2.7% |
| Covered Lines: | 585 |
| Relevant Lines: | 655 |
AsafManela
This is a partial fix for #42. The cross validation was hitting a bounds error because the maximum number of coefficients was exceeded, even though I set
maxncoefto be larger in the call tofit. This doesn't fix the bounds error, which by my reading of the code shouldn't happen, but it makes it so that you can pass a largermaxncoefto the model selection routines so the error isn't triggered.