JuliaStats / Lasso.jl

Lasso/Elastic Net linear and generalized linear models
Other
143 stars 31 forks source link

Correctly handling the case λmax = 0. #52

Closed barankarakus closed 3 years ago

barankarakus commented 3 years ago

Two changes: 1) Change to computeλ to ensure λmax = 0 leads to an output of [0] and not [NaN, ..., NaN]. 2) Change to fit! to ensure the case where autoλ = true and λmax = 0 is handled correctly (rather than throwing an error).

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 199


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Lasso.jl 3 4 75.0%
<!-- Total: 14 15 93.33% -->
Files with Coverage Reduction New Missed Lines %
src/Lasso.jl 4 64.16%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 198: 3.3%
Covered Lines: 581
Relevant Lines: 662

💛 - Coveralls