search

JuliaStats / Lasso.jl

Lasso/Elastic Net linear and generalized linear models
Other
143 stars 31 forks source link

Declare error exception or throw warning instead of just using error() #71

Open jolars opened 2 years ago

jolars commented 2 years ago

Consider this line:

https://github.com/JuliaStats/Lasso.jl/blob/ea7415134a69c085d4c9315a4b8111b172cd5c0a/src/coordinate_descent.jl#L619

It would be much better and more kosher to use throw() along with a proper exception.

As an alternative, which I actually think makes more sense, you could just throw a warning instead.