search

JuliaStats / MLBase.jl

A set of functions to support the development of machine learning algorithms
MIT License
185 stars 63 forks source link

Changes for Julia 0.7/1.0 #45

Closed lsindoni closed 6 years ago

lsindoni commented 6 years ago

Closes #44 Minimal adaptations to match the changes in Julia 0.7/1.0.

A non negligible modification is in the iterators CrossValGenerator (see src/crossval.jl) given the replacement of start, next, done with iterate. To maintain compatibility with Julia 0.6.x, I have inserted a version check.

ararslan commented 6 years ago

Somehow Travis got deactivated on this repo, dunno what the deal is with that, so I've reactivated it. The build status will show up the next time you push a commit.

Speaking of Travis, can you change 0.6 in .travis.yml to 0.7 and add 1.0 below it?

lsindoni commented 6 years ago

Thanks for the feedback! 👍 I'll do the required modifications and resubmit.

ararslan commented 6 years ago

Note that you don't have to make a new pull request; you can simply push your changes as extra commits to this branch and we can squash the commits on merge. Just figured I'm mention that in case it's what you meant by "resubmit." Thanks for working on this!

lsindoni commented 6 years ago

Apologies for the responsiveness, these days I'm mostly away. @asbisen has included the necessary changes. Now everything should be ready. Thanks @asbisen and @ararslan.