JuliaStats / MLBase.jl

A set of functions to support the development of machine learning algorithms
MIT License
186 stars 63 forks source link

Upgrade to StatsBase v0.34 #59

Closed AsafManela closed 1 year ago

AsafManela commented 1 year ago
  1. StatsBase.jl v0.34 removed some internal array types used by MLBase. This change adds a dependency to NumericalTypeAliases.jl that provides these type aliases.

https://github.com/JuliaStats/StatsBase.jl/pull/840

  1. Also adding a CompatHelper action

  2. Bumps MLBase version so it can be tagged

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (9128e4f) 78.75% compared to head (d9ee6c2) 78.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ======================================= Coverage 78.75% 78.75% ======================================= Files 7 7 Lines 659 659 ======================================= Hits 519 519 Misses 140 140 ``` | [Files Changed](https://app.codecov.io/gh/JuliaStats/MLBase.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [src/MLBase.jl](https://app.codecov.io/gh/JuliaStats/MLBase.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL01MQmFzZS5qbA==) | `100.00% <ø> (ø)` | | | [src/classification.jl](https://app.codecov.io/gh/JuliaStats/MLBase.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL2NsYXNzaWZpY2F0aW9uLmps) | `90.75% <84.21%> (ø)` | | | [src/perfeval.jl](https://app.codecov.io/gh/JuliaStats/MLBase.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL3BlcmZldmFsLmps) | `95.32% <92.85%> (ø)` | | | [src/utils.jl](https://app.codecov.io/gh/JuliaStats/MLBase.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL3V0aWxzLmps) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AsafManela commented 1 year ago

Hi @ararslan , would you mind taking a look and merging? I need this for a couple of downstream packages.

ararslan commented 1 year ago

It seems worthwhile to me to replace the uses of those type aliases with their definitions in the same manner as https://github.com/JuliaStats/StatsBase.jl/pull/840 rather than adding a new dependency on a package that defines them.

AsafManela commented 1 year ago

I guess I missed your sarcasm here https://github.com/JuliaStats/StatsBase.jl/pull/840#pullrequestreview-1190948271 I'll try to do that.

ararslan commented 1 year ago

Ah, my apologies, the :trollface: in my comment you linked was intended to convey that it wasn't a serious suggestion. I can see how that could be unclear so I hope my comment hasn't been accidentally misguiding people...

AsafManela commented 1 year ago

No worries. I made those changes. Hopefully good to go.

ararslan commented 1 year ago

Registering here: https://github.com/JuliaRegistries/General/pull/89850

Thanks!

AsafManela commented 1 year ago

Thanks for the quick turnaround!