Closed AsafManela closed 1 year ago
Patch coverage: 90.00%
and no project coverage change.
Comparison is base (
9128e4f
) 78.75% compared to head (d9ee6c2
) 78.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @ararslan , would you mind taking a look and merging? I need this for a couple of downstream packages.
It seems worthwhile to me to replace the uses of those type aliases with their definitions in the same manner as https://github.com/JuliaStats/StatsBase.jl/pull/840 rather than adding a new dependency on a package that defines them.
I guess I missed your sarcasm here https://github.com/JuliaStats/StatsBase.jl/pull/840#pullrequestreview-1190948271 I'll try to do that.
Ah, my apologies, the :trollface: in my comment you linked was intended to convey that it wasn't a serious suggestion. I can see how that could be unclear so I hope my comment hasn't been accidentally misguiding people...
No worries. I made those changes. Hopefully good to go.
Registering here: https://github.com/JuliaRegistries/General/pull/89850
Thanks!
Thanks for the quick turnaround!
https://github.com/JuliaStats/StatsBase.jl/pull/840
Also adding a CompatHelper action
Bumps MLBase version so it can be tagged