search

JuliaStats / MixedModels.jl

A Julia package for fitting (statistical) mixed-effects models
http://juliastats.org/MixedModels.jl/stable
MIT License
405 stars 48 forks source link

A test using a deep copy of a model should reset the initial parameter values. #744

Closed dmbates closed 7 months ago

dmbates commented 7 months ago

Because the initial values for the theta parameters are derived from the values stored in the reterms they will be the final parameter estimates if those terms are deep copied to create a new model.

The NLopt optimizers don't object to this but the PRIMA optimizers do.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6fde5ca) 96.33% compared to head (040d50d) 96.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #744 +/- ## ======================================= Coverage 96.33% 96.33% ======================================= Files 34 34 Lines 3353 3353 ======================================= Hits 3230 3230 Misses 123 123 ``` | [Flag](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/744/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [current](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/744/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.33% <ø> (ø)` | | | [minimum](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/744/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.23% <ø> (ø)` | | | [nightly](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/744/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dmbates commented 7 months ago

The nightly tests are failing consistently on this PR. It appears that the download of the datasets fails when installing MixedModelsDatasets package.

palday commented 7 months ago

The nightly tests are failing consistently on this PR. It appears that the download of the datasets fails when installing MixedModelsDatasets package.

Yeah, I've run into this on other repositories as well and I don't know why it's happening -- I can't replicate with a local nightly build.

dmbates commented 7 months ago

@palday Okay to merge this PR without bumping the patch number? This only affects a test and doesn't change the result of the test - just the run time.

palday commented 7 months ago

@dmbates Go for merge without patch bump. 😄