palday commented 7 months ago

This will hopefully make it easier to separate compile vs. runtime changes in performance.

Did behavior change? Did you add need features? If so, please update NEWS.md

[x] add entry in NEWS.md
[x] after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

[x] I've bumped the version appropriately

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.99%. Comparing base (0ad0594) to head (d203396). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #749 +/- ## ======================================= Coverage 96.99% 96.99% ======================================= Files 34 34 Lines 3361 3361 ======================================= Hits 3260 3260 Misses 101 101 ``` | [Flag](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/749/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [current](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/749/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.93% <ø> (ø)` | | | [minimum](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/749/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.87% <ø> (-0.03%)` | :arrow_down: | | [nightly](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/749/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.50% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

Benchmark Report for /home/runner/work/MixedModels.jl/MixedModels.jl

Job Properties

Time of benchmarks:
- Target: 5 Mar 2024 - 19:44
- Baseline: 5 Mar 2024 - 19:49
Package commits:
- Target: e0642c
- Baseline: 510dcc
Julia commits:
- Target: bd47ec
- Baseline: bd47ec
Julia command flags:
- Target: None
- Baseline: -C,native,-J/opt/hostedtoolcache/julia/1.10.2/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update(); Pkg.add(["BenchmarkTools", "StatsModels"])
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with :x:), while a ratio less than 1.0 denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["crossed", "insteval:1"]`	0.74 (5%) :white_check_mark:	1.00 (1%)
`["crossed", "insteval:2"]`	0.74 (5%) :white_check_mark:	1.00 (1%)
`["crossed", "mrk17_exp1:1"]`	0.09 (5%) :white_check_mark:	1.00 (1%)
`["crossed", "penicillin:1"]`	1.02 (5%)	0.99 (1%) :white_check_mark:
`["crossedvector", "d3:1"]`	0.94 (5%) :white_check_mark:	1.00 (1%)
`["crossedvector", "kb07:3"]`	0.45 (5%) :white_check_mark:	1.00 (1%)
`["crossedvector", "mrk17_exp1:2"]`	0.76 (5%) :white_check_mark:	1.00 (1%)
`["nested", "pastes:2"]`	1.00 (5%)	0.99 (1%) :white_check_mark:
`["singlevector", "sleepstudy:2"]`	1.05 (5%) :x:	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["crossed"]
["crossedvector"]
["nested"]
["singlevector"]

Julia versioninfo

Target

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1015-azure #15~22.04.1-Ubuntu SMP Tue Feb 13 01:15:12 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3217 MHz       1977 s          0 s        343 s       2690 s          0 s
       #2  3242 MHz       1766 s          0 s        226 s       3019 s          0 s
       #3  2768 MHz       1773 s          0 s        363 s       2880 s          0 s
       #4  2445 MHz       1517 s          0 s        363 s       3140 s          0 s
  Memory: 15.606487274169922 GB (13688.875 MB free)
  Uptime: 505.21 sec
  Load Avg:  1.74  1.39  0.75
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1015-azure #15~22.04.1-Ubuntu SMP Tue Feb 13 01:15:12 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2508 MHz       3065 s          0 s        486 s       4231 s          0 s
       #2  2618 MHz       2926 s          0 s        414 s       4442 s          0 s
       #3  3243 MHz       2900 s          0 s        695 s       4195 s          0 s
       #4  2445 MHz       2711 s          0 s        469 s       4612 s          0 s
  Memory: 15.606487274169922 GB (13838.203125 MB free)
  Uptime: 783.0 sec
  Load Avg:  1.68  1.7  1.08
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

JuliaStats / MixedModels.jl

Add precompile step for rePCA #749