search

JuliaStats / MixedModels.jl

A Julia package for fitting (statistical) mixed-effects models
http://juliastats.org/MixedModels.jl/stable
MIT License
402 stars 47 forks source link

delegate as many GLMM properties as possible to internal LMM #767

Closed palday closed 2 months ago

palday commented 2 months ago

@dmbates is there a giant footgun I'm missing by swapping to "delegate by default" instead of "delegate by explicit list"?

Did behavior change? Did you add need features? If so, please update NEWS.md

Should we release your changes right away? If so, bump the version:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (c4beee9) to head (484d33b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #767 +/- ## ========================================== - Coverage 96.93% 96.93% -0.01% ========================================== Files 34 34 Lines 3358 3356 -2 ========================================== - Hits 3255 3253 -2 Misses 103 103 ``` | [Flag](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/767/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [current](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.87% <100.00%> (-0.01%)` | :arrow_down: | | [minimum](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.77% <100.00%> (-0.07%)` | :arrow_down: | | [nightly](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.43% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.