JuliaStats / MixedModels.jl

A Julia package for fitting (statistical) mixed-effects models
http://juliastats.org/MixedModels.jl/stable
MIT License
402 stars 47 forks source link

More sophisticated checks in restoreoptsum. #775

Closed dmbates closed 3 weeks ago

dmbates commented 3 weeks ago

Closes #774

Did behavior change? Did you add need features? If so, please update NEWS.md

Should we release your changes right away? If so, bump the version:

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.99%. Comparing base (34899cf) to head (a2b0857).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #775 +/- ## ========================================== + Coverage 96.93% 96.99% +0.06% ========================================== Files 34 34 Lines 3358 3360 +2 ========================================== + Hits 3255 3259 +4 + Misses 103 101 -2 ``` | [Flag](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/775/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [current](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/775/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.93% <100.00%> (+0.06%)` | :arrow_up: | | [minimum](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/775/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.84% <100.00%> (+<0.01%)` | :arrow_up: | | [nightly](https://app.codecov.io/gh/JuliaStats/MixedModels.jl/pull/775/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | `96.50% <100.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

palday commented 3 weeks ago

@dmbates can you add a test with loading a 4.22 optsum? That would also serve as a potential test if we add even more fields (restoreoptsum! would break again and thus we would be reminded to update it).

dmbates commented 3 weeks ago

I added tests and improved coverage slightly.

palday commented 3 weeks ago

@dmbates I made a few changes directly:

dmbates commented 3 weeks ago

Did I accidentally commit a lcov.info file? I use the "Run tests with coverage" option in VS code which creates a lcov.info file and I see you have added that name to .gitignore

palday commented 3 weeks ago

Did I accidentally commit a lcov.info file? I use the "Run tests with coverage" option in VS code which creates a lcov.info file and I see you have added that name to .gitignore

No, but I almost did :joy:

dmbates commented 3 weeks ago

@JuliaRegistrator register

JuliaRegistrator commented 3 weeks ago

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.