JuliaStats / MultivariateStats.jl

A Julia package for multivariate statistics and data analysis (e.g. dimension reduction)
Other
379 stars 86 forks source link

Bug fix & documentation: KernelPCA w/ precomputed X #208

Closed eahenle closed 1 year ago

eahenle commented 1 year ago

Bug: fit(KernelPCA, X; kernel=nothing) mutates X via K = X prior to calling transform! on K Fix: K = copy(X)

Documentation also does not mention the use of kernel=nothing when X is a pre-computed Gramian; added this.

eahenle commented 1 year ago

Also may be worth documenting the fact that fit applies kernel centering (so the user needn't center precomputed kernels). Kind of harmless to leave this undocumented, but also easy enough to mention in the docs.

wildart commented 1 year ago

You fixed the old doc file. Please, fix doc string for fit function.

eahenle commented 1 year ago

I have added the explanation of kernel=nothing to the docstring

wildart commented 1 year ago

Thanks.