search

JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization
Other
91 stars 34 forks source link

Fix #28: Check the elements of X #40

Closed ghost closed 3 years ago

ghost commented 3 years ago

I fixed #28 by adding the error handling to check the elements of X.

ghost commented 3 years ago

@andreasnoack Thank you for correcting the code appropriately.

mileslucas commented 3 years ago

just an FYI this resulted in breaking changes downstream in my package. I didn't notice it until my CI started failing on a PR for a docs update, since the version was bumped to 0.4.2 instead of 0.5.

andreasnoack commented 3 years ago

While it could also be this PR that has caused the breakage, my guess is that it is https://github.com/JuliaStats/NMF.jl/pull/38 that caused it. I added [Breaking] to the title of that PR to indicate that it was breaking but I should also have mentioned it in a comment. @ararslan I might be a good area to make a 0.4.3 release prior to the breaking change and then a new 0.5 release.

ararslan commented 3 years ago

So register a 0.5.0 off of master and a 0.4.3 based on the commit prior to that PR?

ararslan commented 3 years ago

I'm yanking 0.4.3 from the registry (https://github.com/JuliaRegistries/General/pull/24448) and will reregister current master as 0.5.0.

ghost commented 3 years ago

Thank you!! I really appreciate your help in resolving the problem.