Improve greedy coordinate descent algorithm

JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization

Other

90 stars 34 forks source link

Improve greedy coordinate descent algorithm #45

Closed ghost closed 3 years ago

ghost commented 3 years ago

From Issue #43 , I found that src/greedycd.jl had a fatal problem on memory allocation. This pull request improves the problem.

ghost commented 3 years ago

@ararslan, could you please review this PR?

ghost commented 3 years ago

@ararslan Thank you for your review! I modified the code.

ararslan commented 3 years ago

It looks like we don't currently have CI for this repository because we haven't yet moved to GitHub Actions (#46). Have you run the test suite locally with your change to ensure everything is working as intended and there are no new failures?

ghost commented 3 years ago

@ararslan In Julia 1.5.3, this PR passed all tests.