search

JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization
Other
90 stars 34 forks source link

Fix #19: Support replicates #48

Closed ghost closed 3 years ago

ghost commented 3 years ago

This PR resolves #19.

codecov-io commented 3 years ago

Codecov Report

Merging #48 (dfa653d) into master (c5e60bf) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   93.03%   93.10%   +0.07%     
==========================================
  Files          10       10              
  Lines         589      595       +6     
==========================================
+ Hits          548      554       +6     
  Misses         41       41
Impacted Files Coverage Δ
src/interf.jl 94.11% <100.00%> (+1.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5e60bf...dfa653d. Read the comment docs.

ghost commented 3 years ago

@ararslan, could you please review this PR?

ghost commented 3 years ago

@ararslan Yes, you are right. I fixed README.md. Thanks!

ghost commented 3 years ago

@ararslan I'm very sorry about two mistakes. I misunderstood the issue 19 and meaning of replicates, respectively. I'll fix the mistakes as soon as possible.