search

JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization
Other
90 stars 34 forks source link

Add successive projection algorithm #50

Closed ghost closed 3 years ago

ghost commented 3 years ago

This PR resolves #11, #12, and #22 .

Done:

Thank you for the contributions, @ahwillia and @silenj .

codecov-io commented 3 years ago

Codecov Report

Merging #50 (285217a) into master (c69da18) will decrease coverage by 1.01%. The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   93.26%   92.25%   -1.02%     
==========================================
  Files          10       11       +1     
  Lines         609      684      +75     
==========================================
+ Hits          568      631      +63     
- Misses         41       53      +12
Impacted Files Coverage Δ
src/NMF.jl 100.00% <ø> (ø)
src/interf.jl 94.44% <83.33%> (-1.39%) :arrow_down:
src/spa.jl 84.05% <84.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c69da18...285217a. Read the comment docs.

ghost commented 3 years ago

@ahwillia The code in NonNegLeastSquares.jl is used directly because I cannot add the package to Project.toml. If you have any problems about it, please contact me. Thanks.

ahwillia commented 3 years ago

All okay with me 👍

ghost commented 3 years ago

@ararslan, could you please review this PR?