search

JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization
Other
91 stars 34 forks source link

Fix the return type of rsvd #63

Closed ghost closed 3 years ago

ghost commented 3 years ago

fixes #62

Since the return type of rsvd function is not equal to the argument type, this PR resolves the gap. Also, the test code is modified to be able to detect such problems.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@445dc5a). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage          ?   92.27%           
=========================================
  Files             ?       10           
  Lines             ?      660           
  Branches          ?        0           
=========================================
  Hits              ?      609           
  Misses            ?       51           
  Partials          ?        0
Impacted Files Coverage Δ
src/initialization.jl 100.00% <100.00%> (ø)
src/spa.jl 88.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445dc5a...e5f3e9b. Read the comment docs.