JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization
Other
91 stars 34 forks source link

Switch to testsets #72

Closed timholy closed 1 year ago

timholy commented 1 year ago

This may make the tests more reproducible, since we set the seed inside a @testset. See https://github.com/JuliaStats/NMF.jl/pull/70#issuecomment-1396090714

Note that the random number generator is not guaranteed to give the same sequence across all Julia versions, so version-specific failures are still possible, but at least they should be reproducible.

It will also fix a (repeated) warning:

┌ Warning: Assignment to `X` in soft scope is ambiguous because a global variable by the same name exists: `X` will be treated as a new local. Disambiguate by using `local X` to suppress this warning or `global X` to assign to the existing global variable.
└ @ ~/.julia/dev/NMF/test/alspgrad.jl:15
codecov-commenter commented 1 year ago

Codecov Report

Base: 92.38% // Head: 92.38% // No change to project coverage :thumbsup:

Coverage data is based on head (9ef3fec) compared to base (0cc9173). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #72 +/- ## ======================================= Coverage 92.38% 92.38% ======================================= Files 11 11 Lines 709 709 ======================================= Hits 655 655 Misses 54 54 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.