search

JuliaStats / NMF.jl

A Julia package for non-negative matrix factorization
Other
91 stars 34 forks source link

equal comparison between NMF.Results #84

Closed youdongguo closed 1 year ago

youdongguo commented 1 year ago

add equal comparison between NMF.Results and hash of NMF.Results

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.16% :tada:

Comparison is base (07419bf) 92.46% compared to head (0d1453f) 92.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #84 +/- ## ========================================== + Coverage 92.46% 92.63% +0.16% ========================================== Files 11 11 Lines 717 733 +16 ========================================== + Hits 663 679 +16 Misses 54 54 ``` | [Files Changed](https://app.codecov.io/gh/JuliaStats/NMF.jl/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats) | Coverage Δ | | |---|---|---| | [src/common.jl](https://app.codecov.io/gh/JuliaStats/NMF.jl/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaStats#diff-c3JjL2NvbW1vbi5qbA==) | `82.14% <100.00%> (+7.14%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timholy commented 1 year ago

Somehow the changes in #83 crept in here too. This should be a separate change independent of that PR.

timholy commented 1 year ago

Thanks!