search

JuliaStats / NullableArrays.jl

DEPRECATED Prototype of the new JuliaStats NullableArrays package
Other
35 stars 21 forks source link

Fix failure on Windows #157

Closed nalimilan closed 8 years ago

nalimilan commented 8 years ago

The tests failure on Windows wasn't actually Windows-specific at all. It happens when calling cbrt(Nullable{Float16}()) and the underlying value happens to be negative. Should be fixed in Julia (https://github.com/JuliaLang/julia/pull/18803), but in the meantime disable the fast path.

Fixes https://github.com/JuliaStats/NullableArrays.jl/issues/154.

codecov-io commented 8 years ago

Current coverage is 76.54% (diff: 0.00%)

Merging #157 into master will decrease coverage by 8.25%

@@             master       #157   diff @@
==========================================
  Files            14         14          
  Lines           862        857     -5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            731        656    -75   
- Misses          131        201    +70   
  Partials          0          0

Powered by Codecov. Last update 80ac154...a2665ca

nalimilan commented 8 years ago

The relevant tests passed, failures are the old ones.