Fix broadcast() and map() when passed arrays with different eltypes

JuliaStats / NullableArrays.jl

DEPRECATED Prototype of the new JuliaStats NullableArrays package

Other

35 stars 21 forks source link

Fix broadcast() and map() when passed arrays with different eltypes #175

Closed nalimilan closed 7 years ago

nalimilan commented 7 years ago

The explicit T type parameter to lift() forced input values to be of the same type. Turns out it is not needed to force specialization. Also add tests for this.

Fixes https://github.com/JuliaStats/NullableArrays.jl/issues/174

davidagold commented 7 years ago

that depwarn tho

davidagold commented 7 years ago

The nightly failure looks unrelated. Is it new?

nalimilan commented 7 years ago

No, it's been there since the type system changes I think. Anyway AFAIK we should remove operators.jl on 0.6 since we can use the element-wise operators now.