search

JuliaStats / NullableArrays.jl

DEPRECATED Prototype of the new JuliaStats NullableArrays package
Other
35 stars 21 forks source link

Add special lifting semantics for isnull() with map() and broadcast() #185

Open nalimilan opened 7 years ago

nalimilan commented 7 years ago

This is needed to allow isnull.(x) to return something useful. Currently, the nullable_broadcast_eltype() method is needed since inference does not work on lifted functions (we need to call it on the original function).

Fixes https://github.com/JuliaStats/NullableArrays.jl/issues/180.

@davidagold @johnmyleswhite Cf. our previous discussion at https://github.com/JuliaStats/NullableArrays.jl/pull/166#issuecomment-260282404. I think https://github.com/JuliaStats/NullableArrays.jl/issues/180 makes it clear we need something like this soon.

codecov-io commented 7 years ago

Codecov Report

Merging #185 into master will increase coverage by 0.3%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #185     +/-   ##
=========================================
+ Coverage   64.56%   64.86%   +0.3%     
=========================================
  Files          13       13             
  Lines         697      703      +6     
=========================================
+ Hits          450      456      +6     
  Misses        247      247
Impacted Files Coverage Δ
src/map.jl 92% <100%> (+0.69%) :white_check_mark:
src/broadcast.jl 94.87% <100%> (+0.27%) :white_check_mark:
src/lift.jl 96.96% <100%> (+0.19%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0dfe02...3f5590b. Read the comment docs.

nalimilan commented 7 years ago

Will merge this week-end if nobody objects.