Closed cjprybol closed 7 years ago
Merging #188 into master will increase coverage by
0.26%
. The diff coverage is90%
.
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 64.56% 64.82% +0.26%
==========================================
Files 13 13
Lines 697 705 +8
==========================================
+ Hits 450 457 +7
- Misses 247 248 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/primitives.jl | 98.96% <90%> (-1.04%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b584c81...13263b9. Read the comment docs.
I'm not sure what the coverage drop is for in regards to coveralls, but I could open another PR to try and extend test coverage?
Weird that Codecov went up negligibly and Coveralls fell significantly... not sure how to interpret that. I guess I'm inclined to call it a fluke, but I'll leave that up to @nalimilan.
All tests but coveralls are happy again. If @nalimilan is ok with these changes when the sun comes up on his side of the world, then we can merge and I'll followup with another PR to make the same changes for dropnull & dropnull! and add appropriate tests. Thanks for the help and reviews to both of you!
example
before
after