cjprybol commented 7 years ago

Supersedes https://github.com/JuliaStats/NullableArrays.jl/pull/189. Follows the approach of DataArrays https://github.com/JuliaStats/NullableArrays.jl/pull/189#issuecomment-294309229 and removes specialization in favor of a generic optimization as proposed by https://github.com/JuliaLang/julia/issues/21256.

julia> anynull(collect(1:10))
WARNING: anynull(x) is deprecated, use any(isnull, x) instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:64
 [2] anynull(::Array{Int64,1}) at ./deprecated.jl:51
 [3] eval(::Module, ::Any) at ./boot.jl:235
 [4] eval_user_input(::Any, ::Base.REPL.REPLBackend) at ./REPL.jl:66
 [5] macro expansion at ./REPL.jl:97 [inlined]
 [6] (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:73
while loading no file, in expression starting on line 0
false

julia> allnull(collect(1:10))
WARNING: allnull(x) is deprecated, use all(isnull, x) instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:64
 [2] allnull(::Array{Int64,1}) at ./deprecated.jl:51
 [3] eval(::Module, ::Any) at ./boot.jl:235
 [4] eval_user_input(::Any, ::Base.REPL.REPLBackend) at ./REPL.jl:66
 [5] macro expansion at ./REPL.jl:97 [inlined]
 [6] (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:73
while loading no file, in expression starting on line 0
false

julia> allnull(NullableArray(1:10))
WARNING: allnull(x) is deprecated, use all(isnull, x) instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:64
 [2] allnull(::NullableArrays.NullableArray{Int64,1}) at ./deprecated.jl:51
 [3] eval(::Module, ::Any) at ./boot.jl:235
 [4] eval_user_input(::Any, ::Base.REPL.REPLBackend) at ./REPL.jl:66
 [5] macro expansion at ./REPL.jl:97 [inlined]
 [6] (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:73
while loading no file, in expression starting on line 0
false

julia> anynull(NullableArray(1:10))
WARNING: anynull(x) is deprecated, use any(isnull, x) instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:64
 [2] anynull(::NullableArrays.NullableArray{Int64,1}) at ./deprecated.jl:51
 [3] eval(::Module, ::Any) at ./boot.jl:235
 [4] eval_user_input(::Any, ::Base.REPL.REPLBackend) at ./REPL.jl:66
 [5] macro expansion at ./REPL.jl:97 [inlined]
 [6] (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:73
while loading no file, in expression starting on line 0
false

codecov-io commented 7 years ago

Codecov Report

Merging #192 into master will decrease coverage by 0.82%. The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   64.56%   63.74%   -0.83%     
==========================================
  Files          13       13              
  Lines         697      695       -2     
==========================================
- Hits          450      443       -7     
- Misses        247      252       +5

Impacted Files	Coverage Δ
src/nullablevector.jl	`86.84% <100%> (ø)`	:arrow_up:
src/primitives.jl	`100% <100%> (ø)`	:arrow_up:
src/reduce.jl	`80.45% <33.33%> (ø)`	:arrow_up:
src/indexing.jl	`78.04% <66.66%> (ø)`	:arrow_up:
src/subarray.jl	`0% <0%> (-18.52%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b584c81...0f7b25d. Read the comment docs.

cjprybol commented 7 years ago

@nalimilan

nalimilan commented 7 years ago

Thanks and sorry for the delay!

JuliaStats / NullableArrays.jl

Deprecate anynull and allnull #192

Codecov Report