search

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

Fix #133 #134

Closed sethaxen closed 3 years ago

sethaxen commented 3 years ago

This PR implements the fix described in #133.

sethaxen commented 3 years ago

Thanks! Can you approve running the workflow?

andreasnoack commented 3 years ago

Can you approve running the workflow?

Sure. It's the first time I've seen that one.

codecov-commenter commented 3 years ago

Codecov Report

Merging #134 (d81e3ce) into master (84bdd88) will decrease coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   88.51%   88.31%   -0.20%     
==========================================
  Files           9        8       -1     
  Lines         357      351       -6     
==========================================
- Hits          316      310       -6     
  Misses         41       41
Impacted Files Coverage Δ
src/chol.jl 100.00% <100.00%> (ø)
src/pdmat.jl 96.07% <100.00%> (-0.42%) :arrow_down:
src/utils.jl 93.75% <0.00%> (-0.13%) :arrow_down:
src/PDMats.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84bdd88...d81e3ce. Read the comment docs.

JuliaRegistrator commented 3 years ago

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.