Closed devmotion closed 2 years ago
Merging #164 (fb4a0ef) into master (da9fe95) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 8 8
Lines 440 440
=======================================
Hits 395 395
Misses 45 45
Impacted Files | Coverage Δ | |
---|---|---|
src/pdiagmat.jl | 99.03% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update da9fe95...fb4a0ef. Read the comment docs.
LGTM
This PR simplifies
kron
withPDiagMat
and also avoids indexing issues (see #163).On the master branch
This PR
Accidentally, I had pushed the changes directly to the master branch (already reverted it).
Edit: Additionally, the PR fixes some type inference issues:
On the master branch
With this PR