search

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

Deprecate `dim` #170

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

This PR implements the suggestion in https://github.com/JuliaStats/PDMats.jl/issues/169#issuecomment-1166260830 and deprecates dim in favour of LinearAlgebra.checksquare.

Fixes #169.

codecov-commenter commented 2 years ago

Codecov Report

Merging #170 (aa1594f) into master (8d88c15) will decrease coverage by 0.11%. The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   89.77%   89.65%   -0.12%     
==========================================
  Files           8        8              
  Lines         440      435       -5     
==========================================
- Hits          395      390       -5     
  Misses         45       45
Impacted Files Coverage Δ
src/addition.jl 45.23% <50.00%> (ø)
src/generics.jl 85.71% <100.00%> (-1.79%) :arrow_down:
src/pdiagmat.jl 99.03% <100.00%> (ø)
src/pdmat.jl 97.87% <100.00%> (ø)
src/pdsparsemat.jl 94.54% <100.00%> (ø)
src/scalmat.jl 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d88c15...aa1594f. Read the comment docs.