search

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

dim(a) -> LinearAlgebra.checksquare(a) #171

Closed mohamed82008 closed 2 years ago

mohamed82008 commented 2 years ago

It seems one use of dim was not removed from the package when it was deprecated.

codecov-commenter commented 2 years ago

Codecov Report

Merging #171 (173f305) into master (460c452) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files           8        8           
  Lines         437      437           
=======================================
  Hits          393      393           
  Misses         44       44
Impacted Files Coverage Δ
src/scalmat.jl 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 460c452...173f305. Read the comment docs.

andreasnoack commented 2 years ago

Maybe we should fail when hitting deprecated methods in CI.