Improve `convert` definitions

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures

Other

104 stars 43 forks source link

Improve `convert` definitions #179

Closed devmotion closed 11 months ago

devmotion commented 11 months ago

Adds missing convert definitions and improves efficiency of existing ones. For instance, the PR fixes unnecessary calls of cholesky when converting PDMats.

Fixes https://github.com/JuliaStats/Distributions.jl/issues/1781.

Edit: #180 should be merged first.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
src/generics.jl	`100.00%`
src/pdiagmat.jl	`100.00%`
src/pdmat.jl	`100.00%`
src/pdsparsemat.jl	`100.00%`
src/scalmat.jl	`100.00%`

:loudspeaker: Thoughts on this report? Let us know!.