search

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

Fix `/` on Julia >= 1.9 and broken tests #180

Closed devmotion closed 11 months ago

devmotion commented 11 months ago

As the title says, this PR fixes tests on all Julia versions.

The main problem on the master branch is that the return type of /(::AbstractVector, ::AbstractPDMat) is not consistent anymore with the behaviour in LinearAlgebra >= 1.9. I was not able to track down the exact commit where this behaviour changed but since the first alpha release of 1.9 LinearAlgebra returns a vector in these cases whereas in Julia <= 1.8.5 a matrix was returned.

The second problem were the BandedMatrices tests; they were failing due to some upstream problems (only the computations of the reference values were affected it seems) but this could be fixed by simplifying the calculation of the ground truth values.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/pdiagmat.jl 100.00%
src/pdmat.jl 100.00%
src/scalmat.jl 100.00%

:loudspeaker: Thoughts on this report? Let us know!.