search

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

Fix and test broken `quad!` and `invquad!` #190

Closed devmotion closed 1 year ago

devmotion commented 1 year ago

PDMats 0.11.26 broke invquads! due to a bug in the check of the dimensions of the input arguments: https://github.com/JuliaStats/Distributions.jl/issues/1789

This issues was not noticed since quad! and invquad! were not tested.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/PDMats.jl 100.00% <ø> (ø)
src/chol.jl 97.01% <100.00%> (+16.52%) :arrow_up:
src/pdmat.jl 91.73% <100.00%> (+17.35%) :arrow_up:
src/scalmat.jl 97.19% <100.00%> (+7.09%) :arrow_up:
src/pdsparsemat.jl 93.87% <85.71%> (+21.91%) :arrow_up:

... and 3 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

andreasnoack commented 1 year ago

What is going on on nightly?

devmotion commented 1 year ago

I'm not sure, in particular since tests only failed on Ubuntu. I'll rerun them to see if the failures show up persistently.

devmotion commented 1 year ago

Seems we were just unlucky. I guess we should try to fix the RNG if these failures appear more often.