JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

Other factorizations: parametrization or new names? #198

Open timholy opened 8 months ago

timholy commented 8 months ago

Based on https://github.com/mateuszbaran/CovarianceEstimation.jl/issues/90 we're likely to want something like PDMat that supports different factorizations. Two factorizations are currently under discussion:

Both of these can be efficiently checked for positive (semi) definiteness and would seem to fit here. There seem to be multiple instantiations, though: should the existing PDMat be renamed PDCholesky? Or should we add a F<:Factorization{T} parameter? Either is workable, I'm opening this largely to ask for guidance about your preferences.

CC @mateuszbaran

devmotion commented 8 months ago

We are about to unify PDMat and PDSparseMat in #188. This will already introduce a F<:Factorization type parameter, so extending PDMats to other factorizations will be much simpler after this change.