search

JuliaStats / PDMats.jl

Uniform Interface for positive definite matrices of various structures
Other
104 stars 43 forks source link

Typed Matrix constructor and more stable tests #199

Closed jishnub closed 10 months ago

jishnub commented 10 months ago

I've removed the single-index getindex methods, as the AbstractArray fallback methods should suffice.

I've also ensured that the matrices are explicitly hermitian in the tests, which makes it less likely for cholesky to fail due to numerical precision issues. Further, I've added a random seed, which makes the tests easier to reproduce.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cd28425) 91.48% compared to head (c067537) 91.56%.

:exclamation: Current head c067537 differs from pull request most recent head 5710a1b. Consider uploading reports for the commit 5710a1b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #199 +/- ## ========================================== + Coverage 91.48% 91.56% +0.08% ========================================== Files 9 9 Lines 681 676 -5 ========================================== - Hits 623 619 -4 + Misses 58 57 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.