search

JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
158 stars 56 forks source link

CompatHelper: bump compat for "CSV" to "0.7" #100

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 4 years ago

This pull request changes the compat entry for the CSV package from 0.5, 0.6 to 0.5, 0.6, 0.7.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

tlienart commented 3 years ago

bump please; MLJ relies on this and CSV but this implies downgrading CSV to 0.6 and imposes constraints on DataFrames; it looks like a simple case of merge & release given the tests pass

ping @johnmyleswhite ; @DilumAluthge (sorry not sure who has push access, btw if you don't mind giving myself and @ablaom maintainer access that could be pretty useful, thanks!)

DilumAluthge commented 3 years ago

@andreasnoack @ararslan Would it be possible to give the MLJ folk (@tlienart and @ablaom) the commit bit on this repo?

ararslan commented 3 years ago

Thibaut and Anthony have been invited for commit access

iblislin commented 3 years ago

Hi, Could someone tag a release for this update?

tlienart commented 3 years ago

@iblis17 can you double check? the current release (0.6.9) does have CSV 0.7 as far as I'm aware as per the TOML: https://github.com/JuliaStats/RDatasets.jl/blob/master/Project.toml

tlienart commented 3 years ago

ok I just checked and there's an issue but I'm not sure what causes it unfortunately... opening another issue to discuss it, @iblis17 please direct your future messages on #105