search

JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
158 stars 56 forks source link

Hotfix for #177 #118

Closed torfjelde closed 3 years ago

torfjelde commented 3 years ago

Fix for #117 thanks to @devmotion

Seems like it would be a good idea to get this in ASAP and then change back when FileIO.jl has been fixed.

devmotion commented 3 years ago

This PR only raises the lower bound for FileIO, so I don't think it fixes the problem? Depending on the Pkg resolver, users might not even benefit from an upper bound - the new version of RDatasets might not be installed automatically since it would involve downgrading some other packages (such as FileIO).

torfjelde commented 3 years ago

Wait, doesn't 1.5 mean only 1.5.x is allowed?

devmotion commented 3 years ago

No, it means [1.5.0, 2.0.0): https://julialang.github.io/Pkg.jl/v1/compatibility/#Caret-specifiers

torfjelde commented 3 years ago

Hah, yeah I just checked; it's been too long since I've touched [compat].

codecov-io commented 3 years ago

Codecov Report

Merging #118 (8c813df) into master (c2b17d0) will decrease coverage by 2.18%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   84.00%   81.81%   -2.19%     
==========================================
  Files           4        4              
  Lines          25       22       -3     
==========================================
- Hits           21       18       -3     
  Misses          4        4
Impacted Files Coverage Δ
src/datasets.jl 57.14% <0.00%> (-5.36%) :arrow_down:
src/dataset.jl 90.00% <0.00%> (-0.91%) :arrow_down:
src/packages.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2b17d0...8c813df. Read the comment docs.

devmotion commented 3 years ago

Could we check (or does anyone know) if Pkg would install such a hotfix when running ] up?

devmotion commented 3 years ago

I close this PR since the issue is fixed upstream. Maybe https://github.com/JuliaStats/RDatasets.jl/pull/119 could still be useful but that's a separate issue.