JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
160 stars 56 forks source link

CompatHelper: bump compat for "CSV" to "0.9" #125

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the CSV package from 0.5, 0.6, 0.7, 0.8 to 0.5, 0.6, 0.7, 0.8, 0.9.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

leachim commented 3 years ago

Would be very welcome, if this could be merged. I am just facing a compatibility issue, requiring me to have both CSV 0.9, and RDatasets installed.

codecov-commenter commented 2 years ago

Codecov Report

Merging #125 (9b4e622) into master (d85d718) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           3        3           
  Lines          24       24           
=======================================
  Hits           20       20           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d85d718...9b4e622. Read the comment docs.

nalimilan commented 2 years ago

Ah so this makes CI fail on 32-bit due to https://github.com/JuliaData/CSV.jl/issues/913. Not sure what we should do until it's fixed...

nalimilan commented 2 years ago

https://github.com/JuliaRegistries/General/pull/47624