Open asinghvi17 opened 6 months ago
Attention: Patch coverage is 18.18182%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 63.88%. Comparing base (
b1a5959
) to head (4aac673
).
Files | Patch % | Lines |
---|---|---|
src/dataset.jl | 18.18% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The changes look to make sense. I left one comment. I am not a maintainer of this package (and I do not know its internals). Maybe @nalimilan knows who has appropriate knowledge of the internals to approve it. Thank you for working on it.
This is a combined PR for a bunch of different PRs that are currently up. Below is a summary of changes:
dataset
, indicating that the dataframe was generated by RDatasets.jl and mentioning its package and dataset name as a Tuple. This is essentially a callDataFrames.metadata!(df, "RDatasets.jl" => (package_name, dataset_name))
.description
function to RDatasets, make it readable in the REPLPRs #135 from @frankier and #124 from @jbrea are incorporated here.