JuliaStats / RDatasets.jl

Julia package for loading many of the data sets available in R
GNU General Public License v3.0
160 stars 56 forks source link

Prepare for a new version #145

Open asinghvi17 opened 6 months ago

asinghvi17 commented 6 months ago

This is a combined PR for a bunch of different PRs that are currently up. Below is a summary of changes:

PRs #135 from @frankier and #124 from @jbrea are incorporated here.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.88%. Comparing base (b1a5959) to head (4aac673).

Files Patch % Lines
src/dataset.jl 18.18% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #145 +/- ## =========================================== - Coverage 83.33% 63.88% -19.45% =========================================== Files 3 4 +1 Lines 24 36 +12 =========================================== + Hits 20 23 +3 - Misses 4 13 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bkamins commented 6 months ago

The changes look to make sense. I left one comment. I am not a maintainer of this package (and I do not know its internals). Maybe @nalimilan knows who has appropriate knowledge of the internals to approve it. Thank you for working on it.